Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dask: Linear Regression #6513

Merged
merged 3 commits into from
Jul 25, 2023
Merged

Conversation

noahnovsak
Copy link
Contributor

LinearRegressionLearner and the corresponding widget now support DaskTables.

@markotoplak markotoplak added the dask Related (discovered in or needed) to the Dask adaptation label Jul 20, 2023
Orange/base.py Outdated Show resolved Hide resolved
@@ -562,7 +562,7 @@ def nanmode(x, axis=0):
def unique(x, return_counts=False):
""" Equivalent of np.unique that supports sparse or dense matrices. """
if not sp.issparse(x):
return np.unique(x, return_counts=return_counts)
return np.unique(np.asarray(x), return_counts=return_counts)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you remember who called unique?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in owlearnerwidget there's a check_data method, that makes sure that (among other things) Y isn't constant. I can move the computation up there instead if that makes more sense.

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #6513 (f9547a3) into dask (2185346) will increase coverage by 0.00%.
The diff coverage is 90.38%.

Additional details and impacted files
@@           Coverage Diff           @@
##             dask    #6513   +/-   ##
=======================================
  Coverage   87.70%   87.70%           
=======================================
  Files         322      322           
  Lines       69937    69981   +44     
=======================================
+ Hits        61340    61379   +39     
- Misses       8597     8602    +5     

@markotoplak markotoplak merged commit 89e5caf into biolab:dask Jul 25, 2023
14 of 22 checks passed
markotoplak added a commit to markotoplak/orange3 that referenced this pull request Jul 26, 2023
@noahnovsak noahnovsak deleted the dask-linearregression branch July 26, 2023 09:30
markotoplak added a commit that referenced this pull request Aug 15, 2023
markotoplak added a commit that referenced this pull request Aug 17, 2023
markotoplak added a commit that referenced this pull request Aug 21, 2023
markotoplak added a commit that referenced this pull request Sep 4, 2023
markotoplak added a commit that referenced this pull request Sep 14, 2023
markotoplak added a commit to markotoplak/orange3 that referenced this pull request Sep 14, 2023
markotoplak added a commit that referenced this pull request Sep 18, 2023
markotoplak added a commit that referenced this pull request Sep 26, 2023
markotoplak added a commit that referenced this pull request Oct 10, 2023
markotoplak added a commit that referenced this pull request Oct 13, 2023
markotoplak added a commit that referenced this pull request Oct 21, 2023
markotoplak added a commit that referenced this pull request Oct 29, 2023
markotoplak added a commit that referenced this pull request Nov 6, 2023
markotoplak added a commit that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dask Related (discovered in or needed) to the Dask adaptation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants